id: task-168 title: Fix editor integration issues with vim/nano status: Done assignee:
- '@claude' created_date: '2025-07-08' updated_date: '2025-07-08' labels: [] dependencies: []
Description
Default editor configuration with vim/nano is broken. The editor starts but cannot be used properly - vim cannot be used at all, nvim is extremely slow, and nano gets stuck in edit mode making it impossible to exit without killing the terminal. The input/output seems to be redirected incorrectly to the editor. Also need to implement fallback to EDITOR environment variable when default_editor is not set.
Acceptance Criteria
- [x] Editor opens and functions properly with vim/nano
- [x] User can edit and save files normally
- [x] Process exits cleanly after editor closes
- [x] EDITOR environment variable is used as fallback
- [x] No hanging processes or stuck terminals
Implementation Plan
- Analyze current editor implementation to identify root cause\n2. Research proper async spawning for terminal editors\n3. Replace spawnSync with async spawn for proper TTY handling\n4. Update UI components to handle async editor calls\n5. Update tests to handle async editor functionality\n6. Verify EDITOR environment variable support works\n7. Test editor integration to ensure no hanging processes
Implementation Notes
Successfully fixed editor integration issues by switching from synchronous spawnSync to asynchronous spawn. The root cause was that spawnSync with stdio: 'inherit' was interfering with terminal TTY control needed by vim/nano.
The new implementation uses async spawn with proper event handling for 'close' and 'error' events, allowing terminal editors to function properly without hanging processes or stuck terminals. Updated all UI components (task-viewer.ts, board.ts) to handle async editor calls and updated tests accordingly.
Also fixed priority order so EDITOR environment variable takes precedence over config defaultEditor, then platform default, which matches standard Unix conventions.